Akshat-Jain commented on code in PR #17466:
URL: https://github.com/apache/druid/pull/17466#discussion_r1846711428
##########
pom.xml:
##########
@@ -271,6 +272,16 @@
<enabled>false</enabled>
</snapshots>
</repository>
+
+ <!--
+ maven-dependency-plugin:3.1.2 seems to have updated HTTP repository
access behavior.
Review Comment:
> but instead of adding this repo to the main pom; can we only add it for
the extensions-contrib/thrift-extensions module?
I tried that originally. If you look at these 2 commits:
<img width="886" alt="image"
src="https://github.com/user-attachments/assets/8976d3af-d6ff-42de-bcbb-02472bc6565d";>
[First
commit](https://github.com/apache/druid/pull/17466/commits/ea17aa1c463d4cc6e0b6a6ed4b2ba92726251ca7)
added it to the `thrift-extensions` module, but that still caused the same
error: [CI run for that
commit](https://github.com/apache/druid/actions/runs/11782156018/job/32816565859)
[Second
commit](https://github.com/apache/druid/pull/17466/commits/6d127c1e860c0f6751efb18621eff1d938dce087)
moved it to the parent pom, which fixed the issue.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
