cryptoe commented on code in PR #17493:
URL: https://github.com/apache/druid/pull/17493#discussion_r1850601400
##########
processing/src/main/java/org/apache/druid/query/aggregation/SerializedStorage.java:
##########
@@ -45,109 +44,181 @@ public class SerializedStorage<T>
{
private final WriteOutBytes writeOutBytes;
private final StagedSerde<T> serde;
- private final IntSerializer intSerializer = new IntSerializer();
+ private final ByteBuffer itemOffsetsBytes;
+ private final IntBuffer itemSizes;
+
+ private final LongArrayList rowChunkOffsets = new LongArrayList();
+ private int numStored = 0;
+ private int maxSize = 0;
public SerializedStorage(WriteOutBytes writeOutBytes, StagedSerde<T> serde)
Review Comment:
Do we have test cases for this class.
Rest all changes LGTM. .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
