adarshsanjeev commented on code in PR #17493:
URL: https://github.com/apache/druid/pull/17493#discussion_r1851469234
##########
processing/src/main/java/org/apache/druid/segment/nested/NestedCommonFormatColumnSerializer.java:
##########
@@ -76,10 +76,15 @@ public abstract void serializeDictionaries(
protected void writeInternal(FileSmoosher smoosher, Serializer serializer,
String fileName) throws IOException
{
- ColumnSerializerUtils.writeInternal(smoosher, serializer, getColumnName(),
fileName);
+ writeInternal(smoosher, serializer, getColumnName(), fileName);
}
- protected void copyFromTempSmoosh(FileSmoosher smoosher, SmooshedFileMapper
fileMapper) throws IOException
+ protected static void writeInternal(FileSmoosher smoosher, Serializer
serializer, String columnName, String fileName) throws IOException
+ {
+ ColumnSerializerUtils.writeInternal(smoosher, serializer, columnName,
fileName);
+ }
+
Review Comment:
That makes sense. Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
