adarshsanjeev commented on code in PR #17493:
URL: https://github.com/apache/druid/pull/17493#discussion_r1851466910
##########
processing/src/main/java/org/apache/druid/segment/data/CompressedVSizeColumnarIntsSupplier.java:
##########
@@ -308,7 +308,7 @@ protected int _get(ByteBuffer buffer, boolean bigEngian,
int bufferIndex)
}
}
- private class CompressedVSizeColumnarInts implements ColumnarInts
+ public class CompressedVSizeColumnarInts implements ColumnarInts
Review Comment:
Since CompressedVSizeColumnarInts is the parent class of the other classes
in the file. It would be enough for most use cases to have this as public since
it could expose methods which the child classes can override.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
