kfaraz commented on code in PR #17353:
URL: https://github.com/apache/druid/pull/17353#discussion_r1856015927


##########
services/src/main/java/org/apache/druid/cli/CliOverlord.java:
##########
@@ -457,7 +460,8 @@ private void configureOverlordHelpers(Binder binder)
         new InputSourceModule(),
         new SupervisorModule(),
         new LookupSerdeModule(),
-        new SamplerModule()
+        new SamplerModule(),
+        new BrokerServiceModule()

Review Comment:
   We should try to bring in only the required dependencies rather than 
importing the entire broker service module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to