abhishekrb19 commented on code in PR #17353:
URL: https://github.com/apache/druid/pull/17353#discussion_r1862795953


##########
indexing-service/pom.xml:
##########
@@ -195,6 +195,22 @@
             <artifactId>commons-collections4</artifactId>
             <scope>provided</scope>
         </dependency>
+        <dependency>
+            <groupId>com.cronutils</groupId>
+            <artifactId>cron-utils</artifactId>
+            <version>9.2.0</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.druid</groupId>
+            <artifactId>druid-sql</artifactId>

Review Comment:
   This was my initial plan, but that would entail moving Calcite dependencies 
along with several classes from the `sql` module because of how things are 
wired in now. Neither the `processing` module nor the `server` module currently 
depends on Calcite. 
   
   That said, this new feature relies on the Broker to run explain plan 
queries, so perhaps adding this dependency for the client and serde classes in 
the `indexing-service` module is reasonable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to