kfaraz commented on code in PR #17353:
URL: https://github.com/apache/druid/pull/17353#discussion_r1863357224
##########
indexing-service/pom.xml:
##########
@@ -195,6 +195,22 @@
<artifactId>commons-collections4</artifactId>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>com.cronutils</groupId>
+ <artifactId>cron-utils</artifactId>
+ <version>9.2.0</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.druid</groupId>
+ <artifactId>druid-sql</artifactId>
Review Comment:
No, we should definitely not add a Calcite dependency in these modules.
You might need to create some new interfaces and data model classes to make
sure that the clients are able to talk to the Broker without worrying about the
deps required by the actual implementation.
As for the Explain, I think we should remove that for now at least, and
always force the user to pass the datasource name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
