Akshat-Jain commented on code in PR #17170:
URL: https://github.com/apache/druid/pull/17170#discussion_r1877517404
##########
server/src/main/java/org/apache/druid/segment/realtime/appenderator/SinkQuerySegmentWalker.java:
##########
@@ -273,13 +293,20 @@ public <T> QueryRunner<T> getQueryRunnerForSegments(final
Query<T> query, final
// Regardless of whether caching is enabled, do
reportSegmentAndCacheTime outside the
// *possible* caching.
- runner = new MetricsEmittingQueryRunner<>(
+ runner = new SinkMetricsEmittingQueryRunner<>(
emitter,
factory.getToolchest(),
runner,
- QueryMetrics::reportSegmentAndCacheTime,
- queryMetrics ->
queryMetrics.segment(sinkSegmentId.toString())
- ).withWaitMeasuredFromNow();
+ metricsToReport,
+ segmentMetricsAccumulator,
+ new HashSet<>(
Review Comment:
Have made the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
