Akshat-Jain commented on code in PR #17170:
URL: https://github.com/apache/druid/pull/17170#discussion_r1877537475
##########
processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java:
##########
@@ -66,11 +66,11 @@ public void testDefaultQueryMetricsQuery()
.context(ImmutableMap.of("testKey", "testValue"))
.build();
queryMetrics.query(query);
+ queryMetrics.sqlQueryId("dummy");
+ queryMetrics.queryId("dummy");
Review Comment:
This is related to the `userDims` -> `new HashMap<>(userDims)` change.
This test fails if these lines aren't moved before
`queryMetrics.reportQueryTime(0).emit(serviceEmitter)`.
Reason: Previously, doing `queryMetrics.queryId("dummy")` after emit() was
updating `userDims` in `serviceEmitter.getEvents()`, as we had the same
`userDims` being referenced. But with `new HashMap<>(userDims)` change, that
isn't the case anymore.
Let's wait for Rishabh's inputs on the [other
comment](https://github.com/apache/druid/pull/17170#discussion_r1877525509).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
