github-advanced-security[bot] commented on code in PR #17572:
URL: https://github.com/apache/druid/pull/17572#discussion_r1886768182
##########
sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java:
##########
@@ -236,9 +243,9 @@
}
@Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public void configureGuice(DruidInjectorBuilder builder, List<Module>
overrideModules)
{
- delegate.configureGuice(builder);
+ delegate.configureGuice(builder, overrideModules);
Review Comment:
## Deprecated method or constructor invocation
Invoking [QueryComponentSupplier.configureGuice](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8589)
##########
sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java:
##########
@@ -363,8 +370,36 @@
}
@Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public DruidModule getCoreModule()
+ {
+ return DruidModuleCollection.of(
+ new LookylooModule(),
+ new SegmentWranglerModule(),
+ new ExpressionModule(),
+ new QueryRunnerFactoryModule()
+ );
+ }
+
+ @Override
+ public DruidModule getOverrideModule()
+ {
+ return DruidModuleCollection.of();
+ }
+
+ /**
+ * Configures Guice modules (mostly).
+ *
+ * Deprecated; see: {@link
QueryComponentSupplier#configureGuice(DruidInjectorBuilder, List)}
+ */
+ @Deprecated
+ protected void configureGuice(DruidInjectorBuilder builder)
+ {
+ }
+
+ @Override
+ public void configureGuice(DruidInjectorBuilder builder, List<Module>
overrideModules)
{
+ configureGuice(builder);
Review Comment:
## Deprecated method or constructor invocation
Invoking [StandardComponentSupplier.configureGuice](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8590)
##########
sql/src/test/java/org/apache/druid/quidem/DruidAvaticaTestDriver.java:
##########
@@ -99,33 +97,28 @@
{
Closer closer = Closer.create();
- @Provides
- @LazySingleton
- public DruidSchemaCatalog
getLookupNodeService(QueryRunnerFactoryConglomerate conglomerate,
- SpecificSegmentsQuerySegmentWalker walker, PlannerConfig plannerConfig)
- {
- return CalciteTests.createMockRootSchema(
- conglomerate,
- walker,
- plannerConfig,
- CalciteTests.TEST_AUTHORIZER_MAPPER
- );
- }
-
@Provides
@LazySingleton
public DruidConnectionExtras getConnectionExtras(
ObjectMapper objectMapper,
DruidHookDispatcher druidHookDispatcher,
- @Named("isExplainSupported") Boolean isExplainSupported
+ @Named("isExplainSupported") Boolean isExplainSupported,
+ SpecificSegmentsQuerySegmentWalker walker,
Review Comment:
## Useless parameter
The parameter 'walker' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8592)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
