github-advanced-security[bot] commented on code in PR #17572:
URL: https://github.com/apache/druid/pull/17572#discussion_r1892011368
##########
extensions-contrib/compressed-bigdecimal/src/test/java/org/apache/druid/compressedbigdecimal/CompressedBigDecimalSqlAggregatorTestBase.java:
##########
@@ -79,11 +77,9 @@
private static final List<InputRow> ROWS1 =
TestDataBuilder.RAW_ROWS1.stream().map(m ->
TestDataBuilder.createRow(m, SCHEMA)).collect(Collectors.toList());
- @Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public DruidModule getCoreModule()
Review Comment:
## Missing Override annotation
This method overrides [StandardComponentSupplier.getCoreModule](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4785)
##########
extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/quantiles/sql/DoublesSketchSqlAggregatorTest.java:
##########
@@ -90,11 +91,9 @@
super(tempFolderProducer);
}
- @Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public DruidModule getCoreModule()
Review Comment:
## Missing Override annotation
This method overrides [StandardComponentSupplier.getCoreModule](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4789)
##########
extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/hll/sql/HllSketchSqlAggregatorTest.java:
##########
@@ -259,11 +260,9 @@
properties.put(SqlModule.PROPERTY_SQL_APPROX_COUNT_DISTINCT_CHOICE,
HllSketchApproxCountDistinctSqlAggregator.NAME);
}
- @Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public DruidModule getCoreModule()
Review Comment:
## Missing Override annotation
This method overrides [StandardComponentSupplier.getCoreModule](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4788)
##########
extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/theta/sql/ThetaSketchSqlAggregatorTest.java:
##########
@@ -113,11 +114,9 @@
);
}
- @Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public DruidModule getCoreModule()
Review Comment:
## Missing Override annotation
This method overrides [StandardComponentSupplier.getCoreModule](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4790)
##########
extensions-core/testing-tools/src/test/java/org/apache/druid/query/sql/SleepSqlTest.java:
##########
@@ -46,13 +47,11 @@
super(tempFolderProducer);
}
- @Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public DruidModule getCoreModule()
Review Comment:
## Missing Override annotation
This method overrides [StandardComponentSupplier.getCoreModule](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4797)
##########
sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java:
##########
@@ -363,10 +393,45 @@
}
@Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public DruidModule getCoreModule()
+ {
+ return DruidModuleCollection.of(
+ new LookylooModule(),
+ new SegmentWranglerModule(),
+ new ExpressionModule(),
+ new QueryRunnerFactoryModule(),
+ new BuiltInTypesModule(),
+ new TestSqlModule(),
+ new ServerModule(),
+ new LifecycleModule(),
+ new QueryableModule(),
+ new SqlModule()
+ );
+ }
+
+ @Override
+ public DruidModule getOverrideModule()
+ {
+ return DruidModuleCollection.of();
+ }
+
+ /**
+ * Configures Guice modules (mostly).
+ *
+ * Deprecated; see: {@link
QueryComponentSupplier#configureGuice(DruidInjectorBuilder, List)}
+ */
+ @Deprecated
+ protected void configureGuice(DruidInjectorBuilder builder)
Review Comment:
## Useless parameter
The parameter 'builder' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4800)
##########
extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/tuple/sql/ArrayOfDoublesSketchSqlAggregatorTest.java:
##########
@@ -110,11 +111,9 @@
super(tempFolderProducer);
}
- @Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public DruidModule getCoreModule()
Review Comment:
## Missing Override annotation
This method overrides [StandardComponentSupplier.getCoreModule](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4791)
##########
extensions-core/druid-bloom-filter/src/test/java/org/apache/druid/query/aggregation/bloom/sql/BloomFilterSqlAggregatorTest.java:
##########
@@ -76,11 +77,9 @@
super(tempFolderProducer);
}
- @Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public DruidModule getCoreModule()
Review Comment:
## Missing Override annotation
This method overrides [StandardComponentSupplier.getCoreModule](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4787)
##########
extensions-contrib/tdigestsketch/src/test/java/org/apache/druid/query/aggregation/tdigestsketch/sql/TDigestSketchSqlAggregatorTest.java:
##########
@@ -70,11 +71,9 @@
super(tempFolderProducer);
}
- @Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public DruidModule getCoreModule()
Review Comment:
## Missing Override annotation
This method overrides [StandardComponentSupplier.getCoreModule](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4794)
##########
extensions-core/histogram/src/test/java/org/apache/druid/query/aggregation/histogram/sql/QuantileSqlAggregatorTest.java:
##########
@@ -73,14 +74,11 @@
super(tempFolderProducer);
}
- @Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public DruidModule getCoreModule()
Review Comment:
## Missing Override annotation
This method overrides [StandardComponentSupplier.getCoreModule](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4793)
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/AbstractMSQComponentSupplierDelegate.java:
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.msq.test;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.google.inject.Injector;
+import org.apache.druid.guice.IndexingServiceTuningConfigModule;
+import org.apache.druid.guice.JoinableFactoryModule;
+import org.apache.druid.initialization.DruidModule;
+import org.apache.druid.msq.exec.TestMSQSqlModule;
+import org.apache.druid.msq.guice.MSQExternalDataSourceModule;
+import org.apache.druid.msq.guice.MSQIndexingModule;
+import org.apache.druid.msq.sql.MSQTaskSqlEngine;
+import org.apache.druid.msq.test.CalciteMSQTestsHelper.MSQTestModule;
+import org.apache.druid.server.QueryLifecycleFactory;
+import org.apache.druid.sql.calcite.run.SqlEngine;
+import org.apache.druid.sql.calcite.util.DruidModuleCollection;
+import
org.apache.druid.sql.calcite.util.SqlTestFramework.QueryComponentSupplier;
+import
org.apache.druid.sql.calcite.util.SqlTestFramework.QueryComponentSupplierDelegate;
+
+/**
+ * Upgrade an existing QueryComponentSupplier to support MSQ tests.
+ */
+public class AbstractMSQComponentSupplierDelegate extends
QueryComponentSupplierDelegate {
+
+ public AbstractMSQComponentSupplierDelegate(QueryComponentSupplier delegate)
+ {
+ super(delegate);
+ }
+
+ public DruidModule getCoreModule()
Review Comment:
## Missing Override annotation
This method overrides [QueryComponentSupplierDelegate.getCoreModule](1); it
is advisable to add an Override annotation.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4786)
##########
extensions-core/druid-bloom-filter/src/test/java/org/apache/druid/query/filter/sql/BloomDimFilterSqlTest.java:
##########
@@ -58,11 +59,12 @@
super(tempFolderProducer);
}
- @Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public DruidModule getCoreModule()
Review Comment:
## Missing Override annotation
This method overrides [StandardComponentSupplier.getCoreModule](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4796)
##########
extensions-core/histogram/src/test/java/org/apache/druid/query/aggregation/histogram/sql/FixedBucketsHistogramQuantileSqlAggregatorTest.java:
##########
@@ -74,11 +75,9 @@
super(tempFolderProducer);
}
- @Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public DruidModule getCoreModule()
Review Comment:
## Missing Override annotation
This method overrides [StandardComponentSupplier.getCoreModule](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4792)
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/CalciteMSQTestsHelper.java:
##########
@@ -120,71 +125,119 @@
*/
public class CalciteMSQTestsHelper
{
- public static List<Module> fetchModules(
- Function<String, File> tempFolderProducer,
- TestGroupByBuffers groupByBuffers
- )
+ public static final class MSQTestModule implements DruidModule
{
- File cacheManagerDir = tempFolderProducer.apply("test");
- File storageDir = tempFolderProducer.apply("localsegments");
+ @Override
+ public void configure(Binder binder)
+ {
+ binder.bind(AppenderatorsManager.class).toProvider(() -> null);
- Module customBindings =
- binder -> {
- binder.bind(AppenderatorsManager.class).toProvider(() -> null);
+ // Requirements of JoinableFactoryModule
+
binder.bind(SegmentManager.class).toInstance(EasyMock.createMock(SegmentManager.class));
- // Requirements of JoinableFactoryModule
-
binder.bind(SegmentManager.class).toInstance(EasyMock.createMock(SegmentManager.class));
+ binder.bind(new TypeLiteral<Set<NodeRole>>()
+ {
+ }).annotatedWith(Self.class).toInstance(ImmutableSet.of(NodeRole.PEON));
- binder.bind(new TypeLiteral<Set<NodeRole>>()
- {
-
}).annotatedWith(Self.class).toInstance(ImmutableSet.of(NodeRole.PEON));
+ DruidProcessingConfig druidProcessingConfig = new DruidProcessingConfig()
+ {
+ @Override
+ public String getFormatString()
+ {
+ return "test";
+ }
+ };
+
binder.bind(DruidProcessingConfig.class).toInstance(druidProcessingConfig);
+ binder.bind(QueryProcessingPool.class)
+ .toInstance(new
ForwardingQueryProcessingPool(Execs.singleThreaded("Test-runner-processing-pool")));
- DruidProcessingConfig druidProcessingConfig = new
DruidProcessingConfig()
- {
- @Override
- public String getFormatString()
- {
- return "test";
- }
- };
-
binder.bind(DruidProcessingConfig.class).toInstance(druidProcessingConfig);
- binder.bind(QueryProcessingPool.class)
- .toInstance(new
ForwardingQueryProcessingPool(Execs.singleThreaded("Test-runner-processing-pool")));
+ binder.bind(Bouncer.class).toInstance(new Bouncer(1));
+ }
+
+ @Provides
+ public SegmentCacheManager provideSegmentCacheManager(/*
+ * ObjectMapper
+ * testMapper,
+ */ TempDirProducer
tempDirProducer)
+ {
- // Select queries donot require this
- Injector dummyInjector =
GuiceInjectors.makeStartupInjectorWithModules(
- ImmutableList.of(
- binder1 -> {
-
binder1.bind(ExprMacroTable.class).toInstance(CalciteTests.createExprMacroTable());
-
binder1.bind(DataSegment.PruneSpecsHolder.class).toInstance(DataSegment.PruneSpecsHolder.DEFAULT);
- }
- )
- );
- ObjectMapper testMapper =
MSQTestBase.setupObjectMapper(dummyInjector);
- SegmentCacheManager segmentCacheManager = new
SegmentCacheManagerFactory(TestIndex.INDEX_IO, testMapper)
- .manufacturate(cacheManagerDir);
- LocalDataSegmentPusherConfig config = new
LocalDataSegmentPusherConfig();
- MSQTestSegmentManager segmentManager = new
MSQTestSegmentManager(segmentCacheManager);
- config.storageDirectory = storageDir;
- binder.bind(DataSegmentPusher.class).toProvider(() -> new
MSQTestDelegateDataSegmentPusher(
- new LocalDataSegmentPusher(config),
- segmentManager
- ));
- binder.bind(DataSegmentAnnouncer.class).toInstance(new
NoopDataSegmentAnnouncer());
- binder.bind(DataSegmentProvider.class)
- .toInstance((segmentId, channelCounters, isReindex) ->
getSupplierForSegment(tempFolderProducer, segmentId));
-
binder.bind(DataServerQueryHandlerFactory.class).toInstance(getTestDataServerQueryHandlerFactory());
+ Injector dummyInjector = GuiceInjectors.makeStartupInjectorWithModules(
+ ImmutableList.of(
+ binder1 -> {
+
binder1.bind(ExprMacroTable.class).toInstance(CalciteTests.createExprMacroTable());
+
binder1.bind(DataSegment.PruneSpecsHolder.class).toInstance(DataSegment.PruneSpecsHolder.DEFAULT);
+ }
+ )
+ );
+ // FIXME: this is dodgy... we should not be creating a new ObjectMapper
+ // here
+ ObjectMapper testMapper = MSQTestBase.setupObjectMapper(dummyInjector);
- GroupByQueryConfig groupByQueryConfig = new GroupByQueryConfig();
- GroupingEngine groupingEngine =
GroupByQueryRunnerTest.makeQueryRunnerFactory(
- groupByQueryConfig,
- groupByBuffers
- ).getGroupingEngine();
- binder.bind(GroupingEngine.class).toInstance(groupingEngine);
- binder.bind(Bouncer.class).toInstance(new Bouncer(1));
- };
+ return new SegmentCacheManagerFactory(TestIndex.INDEX_IO, testMapper)
+ .manufacturate(tempDirProducer.newTempFolder("test"));
+ }
+
+ @Provides
+ public LocalDataSegmentPusherConfig
provideLocalDataSegmentPusherConfig(TempDirProducer tempDirProducer)
+ {
+ LocalDataSegmentPusherConfig config = new LocalDataSegmentPusherConfig();
+ config.storageDirectory = tempDirProducer.newTempFolder("localsegments");
+ return config;
+ }
+
+ @Provides
+ public MSQTestSegmentManager
provideMSQTestSegmentManager(SegmentCacheManager segmentCacheManager)
+ {
+ return new MSQTestSegmentManager(segmentCacheManager);
+ }
+
+ @Provides
+ public DataSegmentPusher
provideDataSegmentPusher(LocalDataSegmentPusherConfig config,
+ MSQTestSegmentManager segmentManager)
+ {
+ return new MSQTestDelegateDataSegmentPusher(new
LocalDataSegmentPusher(config), segmentManager);
+ }
+
+ @Provides
+ public DataSegmentAnnouncer provideDataSegmentAnnouncer()
+ {
+ return new NoopDataSegmentAnnouncer();
+ }
+
+ @Provides
+ public DataSegmentProvider provideDataSegmentProvider(TempDirProducer
tempDirProducer)
+ {
+ return (segmentId, channelCounters,
+ isReindex) -> getSupplierForSegment(tempDirProducer::newTempFolder,
segmentId);
+ }
+
+ @Provides
+ public DataServerQueryHandlerFactory provideDataServerQueryHandlerFactory()
+ {
+ return getTestDataServerQueryHandlerFactory();
+ }
+
+ @Provides
+ @LazySingleton
+ GroupingEngine getGroupingEngine(GroupByQueryConfig groupByQueryConfig,
TestGroupByBuffers groupByBuffers)
+ {
+ GroupingEngine groupingEngine =
GroupByQueryRunnerTest.makeQueryRunnerFactory(
+ groupByQueryConfig,
+ groupByBuffers
+ ).getGroupingEngine();
+ return groupingEngine;
+ }
+
+ }
+
+ @Deprecated
+ public static List<Module> fetchModules(
+ Function<String, File> tempFolderProducer,
Review Comment:
## Useless parameter
The parameter 'tempFolderProducer' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4798)
##########
extensions-core/stats/src/test/java/org/apache/druid/query/aggregation/variance/sql/VarianceSqlAggregatorTest.java:
##########
@@ -85,11 +86,9 @@
super(tempFolderProducer);
}
- @Override
- public void configureGuice(DruidInjectorBuilder builder)
+ public DruidModule getCoreModule()
Review Comment:
## Missing Override annotation
This method overrides [StandardComponentSupplier.getCoreModule](1); it is
advisable to add an Override annotation.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4795)
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/CalciteMSQTestsHelper.java:
##########
@@ -120,71 +125,119 @@
*/
public class CalciteMSQTestsHelper
{
- public static List<Module> fetchModules(
- Function<String, File> tempFolderProducer,
- TestGroupByBuffers groupByBuffers
- )
+ public static final class MSQTestModule implements DruidModule
{
- File cacheManagerDir = tempFolderProducer.apply("test");
- File storageDir = tempFolderProducer.apply("localsegments");
+ @Override
+ public void configure(Binder binder)
+ {
+ binder.bind(AppenderatorsManager.class).toProvider(() -> null);
- Module customBindings =
- binder -> {
- binder.bind(AppenderatorsManager.class).toProvider(() -> null);
+ // Requirements of JoinableFactoryModule
+
binder.bind(SegmentManager.class).toInstance(EasyMock.createMock(SegmentManager.class));
- // Requirements of JoinableFactoryModule
-
binder.bind(SegmentManager.class).toInstance(EasyMock.createMock(SegmentManager.class));
+ binder.bind(new TypeLiteral<Set<NodeRole>>()
+ {
+ }).annotatedWith(Self.class).toInstance(ImmutableSet.of(NodeRole.PEON));
- binder.bind(new TypeLiteral<Set<NodeRole>>()
- {
-
}).annotatedWith(Self.class).toInstance(ImmutableSet.of(NodeRole.PEON));
+ DruidProcessingConfig druidProcessingConfig = new DruidProcessingConfig()
+ {
+ @Override
+ public String getFormatString()
+ {
+ return "test";
+ }
+ };
+
binder.bind(DruidProcessingConfig.class).toInstance(druidProcessingConfig);
+ binder.bind(QueryProcessingPool.class)
+ .toInstance(new
ForwardingQueryProcessingPool(Execs.singleThreaded("Test-runner-processing-pool")));
- DruidProcessingConfig druidProcessingConfig = new
DruidProcessingConfig()
- {
- @Override
- public String getFormatString()
- {
- return "test";
- }
- };
-
binder.bind(DruidProcessingConfig.class).toInstance(druidProcessingConfig);
- binder.bind(QueryProcessingPool.class)
- .toInstance(new
ForwardingQueryProcessingPool(Execs.singleThreaded("Test-runner-processing-pool")));
+ binder.bind(Bouncer.class).toInstance(new Bouncer(1));
+ }
+
+ @Provides
+ public SegmentCacheManager provideSegmentCacheManager(/*
+ * ObjectMapper
+ * testMapper,
+ */ TempDirProducer
tempDirProducer)
+ {
- // Select queries donot require this
- Injector dummyInjector =
GuiceInjectors.makeStartupInjectorWithModules(
- ImmutableList.of(
- binder1 -> {
-
binder1.bind(ExprMacroTable.class).toInstance(CalciteTests.createExprMacroTable());
-
binder1.bind(DataSegment.PruneSpecsHolder.class).toInstance(DataSegment.PruneSpecsHolder.DEFAULT);
- }
- )
- );
- ObjectMapper testMapper =
MSQTestBase.setupObjectMapper(dummyInjector);
- SegmentCacheManager segmentCacheManager = new
SegmentCacheManagerFactory(TestIndex.INDEX_IO, testMapper)
- .manufacturate(cacheManagerDir);
- LocalDataSegmentPusherConfig config = new
LocalDataSegmentPusherConfig();
- MSQTestSegmentManager segmentManager = new
MSQTestSegmentManager(segmentCacheManager);
- config.storageDirectory = storageDir;
- binder.bind(DataSegmentPusher.class).toProvider(() -> new
MSQTestDelegateDataSegmentPusher(
- new LocalDataSegmentPusher(config),
- segmentManager
- ));
- binder.bind(DataSegmentAnnouncer.class).toInstance(new
NoopDataSegmentAnnouncer());
- binder.bind(DataSegmentProvider.class)
- .toInstance((segmentId, channelCounters, isReindex) ->
getSupplierForSegment(tempFolderProducer, segmentId));
-
binder.bind(DataServerQueryHandlerFactory.class).toInstance(getTestDataServerQueryHandlerFactory());
+ Injector dummyInjector = GuiceInjectors.makeStartupInjectorWithModules(
+ ImmutableList.of(
+ binder1 -> {
+
binder1.bind(ExprMacroTable.class).toInstance(CalciteTests.createExprMacroTable());
+
binder1.bind(DataSegment.PruneSpecsHolder.class).toInstance(DataSegment.PruneSpecsHolder.DEFAULT);
+ }
+ )
+ );
+ // FIXME: this is dodgy... we should not be creating a new ObjectMapper
+ // here
+ ObjectMapper testMapper = MSQTestBase.setupObjectMapper(dummyInjector);
- GroupByQueryConfig groupByQueryConfig = new GroupByQueryConfig();
- GroupingEngine groupingEngine =
GroupByQueryRunnerTest.makeQueryRunnerFactory(
- groupByQueryConfig,
- groupByBuffers
- ).getGroupingEngine();
- binder.bind(GroupingEngine.class).toInstance(groupingEngine);
- binder.bind(Bouncer.class).toInstance(new Bouncer(1));
- };
+ return new SegmentCacheManagerFactory(TestIndex.INDEX_IO, testMapper)
+ .manufacturate(tempDirProducer.newTempFolder("test"));
+ }
+
+ @Provides
+ public LocalDataSegmentPusherConfig
provideLocalDataSegmentPusherConfig(TempDirProducer tempDirProducer)
+ {
+ LocalDataSegmentPusherConfig config = new LocalDataSegmentPusherConfig();
+ config.storageDirectory = tempDirProducer.newTempFolder("localsegments");
+ return config;
+ }
+
+ @Provides
+ public MSQTestSegmentManager
provideMSQTestSegmentManager(SegmentCacheManager segmentCacheManager)
+ {
+ return new MSQTestSegmentManager(segmentCacheManager);
+ }
+
+ @Provides
+ public DataSegmentPusher
provideDataSegmentPusher(LocalDataSegmentPusherConfig config,
+ MSQTestSegmentManager segmentManager)
+ {
+ return new MSQTestDelegateDataSegmentPusher(new
LocalDataSegmentPusher(config), segmentManager);
+ }
+
+ @Provides
+ public DataSegmentAnnouncer provideDataSegmentAnnouncer()
+ {
+ return new NoopDataSegmentAnnouncer();
+ }
+
+ @Provides
+ public DataSegmentProvider provideDataSegmentProvider(TempDirProducer
tempDirProducer)
+ {
+ return (segmentId, channelCounters,
+ isReindex) -> getSupplierForSegment(tempDirProducer::newTempFolder,
segmentId);
+ }
+
+ @Provides
+ public DataServerQueryHandlerFactory provideDataServerQueryHandlerFactory()
+ {
+ return getTestDataServerQueryHandlerFactory();
+ }
+
+ @Provides
+ @LazySingleton
+ GroupingEngine getGroupingEngine(GroupByQueryConfig groupByQueryConfig,
TestGroupByBuffers groupByBuffers)
+ {
+ GroupingEngine groupingEngine =
GroupByQueryRunnerTest.makeQueryRunnerFactory(
+ groupByQueryConfig,
+ groupByBuffers
+ ).getGroupingEngine();
+ return groupingEngine;
+ }
+
+ }
+
+ @Deprecated
+ public static List<Module> fetchModules(
+ Function<String, File> tempFolderProducer,
+ TestGroupByBuffers groupByBuffers
Review Comment:
## Useless parameter
The parameter 'groupByBuffers' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4799)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
