github-advanced-security[bot] commented on code in PR #17572:
URL: https://github.com/apache/druid/pull/17572#discussion_r1888532957
##########
sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java:
##########
@@ -896,13 +931,17 @@
// test pulls in a module, then pull in that module, even though we are
// not the Druid node to which the module is scoped.
.ignoreLoadScopes();
- List<Module> overrideModules = new ArrayList<>(builder.overrideModules);
- overrideModules.add(new LookylooModule());
- overrideModules.add(new SqlAggregationModule());
- overrideModules.add(new SegmentWranglerModule());
- overrideModules.add(new ExpressionModule());
- overrideModules.add(testSetupModule());
+ ArrayList<Module> overrideModules = new
ArrayList<>(builder.overrideModules);
+
+ injectorBuilder.add(componentSupplier.getCoreModule());
+ injectorBuilder.add(new BuiltInTypesModule());
+ injectorBuilder.add(new TestSqlModule());
+ injectorBuilder.add(new LifecycleModule());
+ injectorBuilder.add(new QueryableModule());
+ overrideModules.add(new TestSetupModule(builder));
Review Comment:
## Deprecated method or constructor invocation
Invoking [QueryComponentSupplier.configureGuice](1) should be avoided
because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8591)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
