kgyrtkirk commented on code in PR #17592:
URL: https://github.com/apache/druid/pull/17592#discussion_r1914381902
##########
integration-tests/docker/base-setup.sh:
##########
@@ -31,10 +31,23 @@ apt-get install -y default-mysql-server
# Supervisor
apt-get install -y supervisor
-# Zookeeper
+# Download function
+download_file() {
+ local dest=$1
+ local host=$2
+
+ if ! wget --inet4-only --quiet --continue --output-document="$dest" "$host"
Review Comment:
thank you for the details/changes; looks better!
I feel like the current changes will be volatile to the same issues you've
seen before you've started fixing this...
you could simulate connection refused/etc error-s with iptables commands
like:
```
iptables -A OUTPUT -d 135.181.214.104 -j DROP
iptables -A OUTPUT -d 88.99.208.237 -j DROP
```
or using a tool like [saboteur](https://github.com/tomakehurst/saboteur)
* I think you could use `--retry-connrefused` and/or other options to force
connection retries?
* restricting to ipv4 could possibly hit back later....I don't think it
should be restricted to that
* instead of a custom message; wouldn't it be enough to use `-nv` ?
* nit: why did you added `--continue`? could it be already there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
