GWphua commented on code in PR #17592:
URL: https://github.com/apache/druid/pull/17592#discussion_r1914486042
##########
integration-tests/docker/base-setup.sh:
##########
@@ -31,10 +31,23 @@ apt-get install -y default-mysql-server
# Supervisor
apt-get install -y supervisor
-# Zookeeper
+# Download function
+download_file() {
+ local dest=$1
+ local host=$2
+
+ if ! wget --inet4-only --quiet --continue --output-document="$dest" "$host"
Review Comment:
Hi @kgyrtkirk, thanks for the tip in simulating network problems, I will try
to simulate the problem with your tip. Also, good points made about using
`--retry-connrefused` instead of restricting `ipv4`, and `-nv` instead of
`--quiet`.
About the nit:
`--continue` is added as an attempt to target the timeout problem. I read
that it will help [wget to resume downloading the file](
https://stackoverflow.com/questions/60242890/wget-to-resume-downloading-files-from-where-it-stopped),
so I added it in to reduce the chances that wget is working, but the download
speed is too slow to satisfy the timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
