GWphua commented on code in PR #17592:
URL: https://github.com/apache/druid/pull/17592#discussion_r1915865017
##########
integration-tests/docker/base-setup.sh:
##########
@@ -31,10 +31,23 @@ apt-get install -y default-mysql-server
# Supervisor
apt-get install -y supervisor
-# Zookeeper
+# Download function
+download_file() {
+ local dest=$1
+ local host=$2
+
+ if ! wget --inet4-only --quiet --continue --output-document="$dest" "$host"
Review Comment:
I have made the changes to the `wget` options, and we can now see that using
`--retry-connrefused` will allow us to wget with [20 retries]
(https://github.com/apache/druid/actions/runs/12764706329/job/35581015481?pr=17592)
instead of not retrying prior to this PR.
However, I found that using `-nv` may confuse people. PTAL at the `wget`
output for `-nv`:
```
#8 14.22 Processing triggers for libc-bin (2.28-10+deb10u1) ...
#8 148.7 failed: Connection timed out.
#8 283.9 failed: Connection timed out.
#8 283.9 failed: Network is unreachable.
#8 283.9 failed: Network is unreachable.
#8 419.0 failed: Connection timed out.
#8 554.2 failed: Connection timed out.
#8 554.2 failed: Network is unreachable.
#8 554.2 failed: Network is unreachable.
```
For example, in this case, it is not obvious that:
1. We are using `wget` to download zookeeper.
2. The IP addresses are not shown, this may give users an impression that
`wget` is alternating between `Connection timed out` and `Network is
unreachable` for the same IP host.
As such, I have changed the log settings to the default (`--verbose`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
