pissang commented on a change in pull request #15141:
URL: https://github.com/apache/echarts/pull/15141#discussion_r650401192
##########
File path: src/chart/treemap/TreemapView.ts
##########
@@ -979,6 +979,9 @@ function renderNode(
}
);
+ if (!isShow) {
Review comment:
textEl is also needed when label is set `emphasis.show = true`. Perhaps
we can check if `textEl` is null in the next line instead of check if show on
normal state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
