pissang commented on a change in pull request #15141:
URL: https://github.com/apache/echarts/pull/15141#discussion_r651086752
##########
File path: src/chart/treemap/TreemapView.ts
##########
@@ -979,6 +979,9 @@ function renderNode(
}
);
+ if (!isShow) {
Review comment:
@susiwen8 Year we need to check all four states. But it has been done in
`setLabelStyle`. text element will be created if any state is set `show: true`.
So I think we only need to check if `rectEl.getTextContent()` exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
