aloktomarr commented on PR #21698: URL: https://github.com/apache/echarts/pull/21698#issuecomment-5019356765
Thanks for the review and the helpful context!! Thanks for explaining the Vue case too, where the chart instance becomes reactive and [seriesModel.coordinateSystem] gets lost, and how `shallowRef`/`markRaw` help before 6.1.0 (and that #21293 fixes it from 6.1.0). That's a different cause from the case this PR handles, where a series uses a coordinate system that isn't registered or declared. I've pushed a follow-up commit that adds a dev warning before skipping the render, instead of skipping silently: [ECharts] Heatmap will not be rendered because its coordinate system is missing. Please make sure the coordinate system is declared and its component is imported. It only logs once so it doesn't repeat on every render. Please let me know if you would like different wording. Thanks again!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
