aloktomarr opened a new pull request, #21698: URL: https://github.com/apache/echarts/pull/21698
## Brief Information This pull request is in the type of: - [x] bug fixing - [ ] new feature - [ ] others ### What does this PR do? Prevents `HeatmapView.render` from throwing when a heatmap's coordinate system cannot be resolved. ### Fixed issues - close #19060 ## Details ### Before: What was the problem? `HeatmapView.render` read `seriesModel.coordinateSystem.type` without checking that the coordinate system existed. When a heatmap references a coordinate system whose component is missing (e.g. `coordinateSystem: 'calendar'` or `'bmap'` not registered), `coordinateSystem` is `undefined`, so `coordSys.type` threw `Cannot read properties of undefined (reading 'type')`, aborting the entire render. `incrementalRender` already guarded this case with `if (coordSys)`, but `render` did not. ### After: How does it behave after the fixing? `render` now returns early when the coordinate system is missing (same guard as `incrementalRender`), so the misconfiguration is skipped gracefully — ECharts still emits its usual "coordinate system cannot be found" warning — instead of throwing. Added a regression unit test (`test/ut/spec/series/heatmap.test.ts`). ## Document Info - [x] This PR doesn't relate to document changes ## Misc ### Security Checking - [ ] This PR uses security-sensitive Web APIs. ### ZRender Changes - [ ] This PR depends on ZRender changes. ### Merging options - [x] Please squash the commits into a single one when merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
