plainheart commented on code in PR #198:
URL: https://github.com/apache/echarts-handbook/pull/198#discussion_r4092095430
##########
contents/en/how-to/interaction/drag.md:
##########
@@ -263,6 +268,7 @@ function onPointDragging(dataIndex, dx, dy) {
}
]
});
+ updatePosition();
Review Comment:
Hi, thanks for your contribution! I think the best way is to update the
handle's position in the `ondragend` event handler like commit
https://github.com/apache/echarts-examples/commit/88ca004030e999073a15303e5fe32462b8fefae2.
If we update position in the dragging handler, the dragging process can become
not smooth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
