alaahong commented on PR #709: URL: https://github.com/apache/fesod/pull/709#issuecomment-3568077773
> Hi @alaahong, I checked the Netlify logs and found the issue. The deployment is failing with this error: > > > No package.json was found in "/opt/build/repo" > > This happens because Netlify is trying to run `pnpm build` from the repository root. Looking at the Netlify build settings, they appear to have been changed or not configured properly. Since I don't have access to the `fesod` Netlify project to verify or update these settings. Could you help check what the current configuration is? And also since we're already using GitHub Actions to handle the build and deployment through the workflow, the Netlify automatic builds should be disabled to avoid conflicts. This is my current repo project build settings: <img alt="image" width="578" height="408" src="https://private-user-images.githubusercontent.com/63136897/517804404-8f7651b8-bc56-45cb-9ea8-3a6ce5116efe.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjM4ODYwOTUsIm5iZiI6MTc2Mzg4NTc5NSwicGF0aCI6Ii82MzEzNjg5Ny81MTc4MDQ0MDQtOGY3NjUxYjgtYmM1Ni00NWNiLTllYTgtM2E2Y2U1MTE2ZWZlLnBuZz9YLUFtei1BbG dvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTExMjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMTIzVDA4MTYzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA2M2MzYzY4NmViYTQ3N2NhYjFlNTJhMjIwY2FkOTliYjMxYmM0ZGUwZjczNDljNDc3Y2I2NDY1M2NhNmI1ZTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.X1gNCx0KYZfvUmCQoeo_jTcCinlVtvNenr0CaBCOp6E"> > > Regarding your commit with `pull_request_target`, I've been looking into this and found there are some security concerns with that approach. I've researched a two-workflow [pattern](https://github.com/apache/fesod/issues/678#issuecomment-3567559178) and implemented it on my fork. Feel free to check it out and give any feedback. Both pull_request and pull_request_target won't work as expected... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
