alaahong commented on PR #709: URL: https://github.com/apache/fesod/pull/709#issuecomment-3568089857
> > Both pull_request and pull_request_target won't work as expected... > > Hi @alaahong, you're right that `pull_request_target` isn't working yet because it's not on the main branch. Actually, both `pull_request_target` and the `workflow_run` pattern I'm proposing need to be merged to main before they work properly. The key difference is security where `pull_request_target` has security risks because it checks out and runs PR code while secrets are available. The two-workflow pattern with `workflow_run` is safer because it separates the untrusted code execution from the secrets access. As token/site id had been resolved now. Can you try to confirm the right configuration on Netlify and CI in Github Action? This PR is used to verify the result, you can raise a new PR if any modify required later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
