ongdisheng commented on PR #709: URL: https://github.com/apache/fesod/pull/709#issuecomment-3568099992
Hi @alaahong, thanks for confirming the token/site ID are resolved! Looking at the Netlify build settings screenshot you shared, I notice it has: > Build command: pnpm build > Publish directory: ./website/build However, this configuration would require setting base directory=`website` and a `pnpm-lock.yaml` file in the website folder, which we don't have. This is likely why the builds are failing. <img width="1072" height="857" alt="image" src="https://github.com/user-attachments/assets/de63705a-766b-4478-b2be-cc9416daab97"; /> I have a suggestion: Since either `pull_request_target` or `workflow_run` approach need to be merged to main before they can work anyway, how about I submit a PR with the secure `workflow_run` approach I've tested on my fork? This approach uses GitHub Actions to handle the entire build and deployment process, so we can leave the Netlify build settings empty similar to what I showed earlier. Once it's merged to main, we can test it with your PR to verify everything works correctly. Let me know what do you think about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
