vorburger commented on a change in pull request #642: FINERACT-724 Upgrade
Spring Boot, Spring and Spring Security to their latest stable version
URL: https://github.com/apache/fineract/pull/642#discussion_r335003703
##########
File path:
fineract-provider/src/main/resources/META-INF/spring/securityContext.xml
##########
@@ -59,31 +60,23 @@
<intercept-url pattern="/api/**"
access="isFullyAuthenticated() and hasAuthority('TWOFACTOR_AUTHENTICATED')"
method="HEAD" requires-channel="https" />
- <custom-filter after="SECURITY_CONTEXT_FILTER"
- ref="basicAuthenticationProcessingFilter" />
+ <custom-filter after="SECURITY_CONTEXT_FILTER"
ref="basicAuthenticationProcessingFilter" />
<custom-filter ref="twoFactorAuthFilter"
after="BASIC_AUTH_FILTER" />
</http>
<beans:bean id="basicAuthenticationEntryPoint"
class="org.springframework.security.web.authentication.www.BasicAuthenticationEntryPoint">
<beans:property name="realmName" value="Fineract
Platform API" />
</beans:bean>
-
- <beans:bean id="passwordEncoder"
-
class="org.springframework.security.authentication.encoding.ShaPasswordEncoder">
- <beans:constructor-arg value="256" />
- </beans:bean>
-
- <beans:bean id="saltSource"
-
class="org.springframework.security.authentication.dao.ReflectionSaltSource">
- <beans:property name="userPropertyToUse" value="id" />
+
+ <beans:bean id="passwordEncoder"
class="org.apache.fineract.infrastructure.core.domain.DefaultPasswordEncoderFactories"
Review comment:
If we have any other reviewers more familiar with Spring Security than I am
currently, it could be useful to have more eyes reviewing the changes in this
file (here and below) ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
