vorburger commented on a change in pull request #642: FINERACT-724 Upgrade
Spring Boot, Spring and Spring Security to their latest stable version
URL: https://github.com/apache/fineract/pull/642#discussion_r334981199
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/WebXmlConfiguration.java
##########
@@ -46,10 +47,12 @@
@Autowired
private TenantAwareBasicAuthenticationFilter
basicAuthenticationProcessingFilter;
+/*
@Bean
public Filter springSecurityFilterChain() {
return new DelegatingFilterProxy();
}
+*/
Review comment:
for future clarify better remove than only comment out... but I'd love more
eyes on this particular change - this is security related - why is this Filter
not required anymore in newer Spring versions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
