vorburger commented on a change in pull request #642: FINERACT-724 Upgrade 
Spring Boot, Spring and Spring Security to their latest stable version
URL: https://github.com/apache/fineract/pull/642#discussion_r334974390
 
 

 ##########
 File path: fineract-provider/dev-dependencies.gradle
 ##########
 @@ -92,17 +89,19 @@ dependencies {
                 //[group: 'com.google.code.findbugs', name: 'jsr305', version: 
'3.0.0']
 
                 [group: 'io.swagger', name: 'swagger-jersey-jaxrs', version: 
'1.5.15'],
-                [group: 'org.springframework', name:'spring-jms'],
-                [group: 'org.apache.activemq', name: 'activemq-broker'],
+                [group: 'org.springframework', name:'spring-jms', version: 
'4.0.7.RELEASE'],
 
 Review comment:
   In an ideal world, in a future PR, it would be really really cool if we 
could just avoid having to repeat using fixed version, and could use the 
implicit versions via Spring BOM dependency management, see 
https://docs.spring.io/spring-boot/docs/current/gradle-plugin/reference/html/#managing-dependencies
 ...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to