vorburger commented on a change in pull request #670: FINERACT-702: Integrate
SpotBugs and fix over 300 high priority issues
URL: https://github.com/apache/fineract/pull/670#discussion_r357919231
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/domain/Sender.java
##########
@@ -789,7 +745,7 @@ protected static String getString(InputStream stream)
throws IOException {
return "";
}
BufferedReader reader = new BufferedReader(
- new InputStreamReader(stream));
+ new InputStreamReader(stream,
Charset.defaultCharset()));
Review comment:
hard-code this to use UTF-8 instead of using platform default charset is
better here, as it make it more repeatable (otherwise it depends on OS
settings, which can lead to hard to understand problems)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
