vorburger commented on a change in pull request #670: FINERACT-702: Integrate
SpotBugs and fix over 300 high priority issues
URL: https://github.com/apache/fineract/pull/670#discussion_r357918587
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/TrialBalance.java
##########
@@ -103,6 +104,8 @@ public boolean equals(Object obj) {
&&
trialBalance.getTransactionDate().equals(this.getTransactionDate());
}
-
-
+ @Override
Review comment:
when I wanted to double check if this new hashCode() here did not forget any
fields (you did not), I noticed that the existing equals() method does not
include amount and closingBalance... doesn't that look (VERY) suspicious? Shall
we fix that as well here while we're at it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
