vorburger commented on a change in pull request #670: FINERACT-702: Integrate SpotBugs and fix over 300 high priority issues URL: https://github.com/apache/fineract/pull/670#discussion_r357919166
########## File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/gcm/domain/Sender.java ########## @@ -18,73 +18,29 @@ */ package org.apache.fineract.infrastructure.gcm.domain; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_CANONICAL_IDS; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_ERROR; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_FAILURE; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_MESSAGE_ID; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_MULTICAST_ID; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_NOTIFICATION_BADGE; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_NOTIFICATION; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_NOTIFICATION_BODY; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_NOTIFICATION_BODY_LOC_ARGS; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_NOTIFICATION_BODY_LOC_KEY; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_NOTIFICATION_CLICK_ACTION; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_NOTIFICATION_COLOR; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_NOTIFICATION_ICON; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_NOTIFICATION_SOUND; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_NOTIFICATION_TAG; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_NOTIFICATION_TITLE; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_NOTIFICATION_TITLE_LOC_ARGS; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_NOTIFICATION_TITLE_LOC_KEY; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_PAYLOAD; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_REGISTRATION_IDS; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_TO; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_RESULTS; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.JSON_SUCCESS; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.PARAM_COLLAPSE_KEY; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.PARAM_DELAY_WHILE_IDLE; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.PARAM_DRY_RUN; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.PARAM_PRIORITY; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.PARAM_CONTENT_AVAILABLE; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.PARAM_RESTRICTED_PACKAGE_NAME; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.PARAM_TIME_TO_LIVE; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.TOKEN_CANONICAL_REG_ID; -import static org.apache.fineract.infrastructure.gcm.GcmConstants.TOPIC_PREFIX; - -import org.apache.fineract.infrastructure.gcm.GcmConstants; -import org.apache.fineract.infrastructure.gcm.exception.InvalidRequestException; -/*import org.json.simple.JSONArray; -import org.json.simple.JSONObject; -import org.json.simple.JSONValue; -import org.json.simple.parser.JSONParser; -import org.json.simple.parser.ParseException;*/ - - - - - - import com.google.gson.Gson; import com.google.gson.JsonArray; import com.google.gson.JsonObject; import com.google.gson.JsonParser; +import org.apache.fineract.infrastructure.gcm.GcmConstants; +import org.apache.fineract.infrastructure.gcm.exception.InvalidRequestException; -import java.io.BufferedReader; -import java.io.Closeable; -import java.io.IOException; -import java.io.InputStream; -import java.io.InputStreamReader; -import java.io.OutputStream; +import java.io.*; import java.net.HttpURLConnection; import java.net.URL; -import java.util.ArrayList; -import java.util.HashMap; -import java.util.List; -import java.util.Map; -import java.util.Random; +import java.nio.charset.Charset; +import java.util.*; import java.util.logging.Level; import java.util.logging.Logger; +import static org.apache.fineract.infrastructure.gcm.GcmConstants.*; + +/*import org.json.simple.JSONArray; Review comment: just completely remove this commented out super old import block ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
