awasum commented on a change in pull request #670: FINERACT-702: Integrate
SpotBugs and fix over 300 high priority issues
URL: https://github.com/apache/fineract/pull/670#discussion_r358141527
##########
File path:
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/CenterDomain.java
##########
@@ -45,7 +44,6 @@ private Builder(final Integer id, final Integer statusid,
final String statuscod
final String name, final String externalId, final Integer
staffId, final int officeID, final String officeName,
final String hierarchy, final ArrayList<HashMap> groupMembers)
{
this.id = id;
- this.accountNo = accountNo;
Review comment:
> this looks suspicious, and worth of a closer investigation..
Call to Builder() never passes accountNo, so setting the class var to itself
makes no sense to me. Maybe, I am wrong. Advice? SpotBugs flags this as
something to be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
