awasum commented on a change in pull request #670: FINERACT-702: Integrate
SpotBugs and fix over 300 high priority issues
URL: https://github.com/apache/fineract/pull/670#discussion_r358150155
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/TrialBalance.java
##########
@@ -103,6 +104,8 @@ public boolean equals(Object obj) {
&&
trialBalance.getTransactionDate().equals(this.getTransactionDate());
}
-
-
+ @Override
Review comment:
Ohh...It does. the JPA entity looks like amount and closingBalance are never
null (when saved to DB). That confused me and I did not check to see the
corresponding equals for it. Fixing this now. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
