awasum commented on a change in pull request #670: FINERACT-702: Integrate
SpotBugs and fix over 300 high priority issues
URL: https://github.com/apache/fineract/pull/670#discussion_r358179089
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
##########
@@ -790,21 +736,20 @@ private void
removeOrModifyTransactionAssociatedWithLoanChargeIfDueAtDisbursemen
LoanTransaction transactionToRemove = null;
List<LoanTransaction> transactions = getLoanTransactions() ;
for (final LoanTransaction transaction : transactions) {
- if (transaction.isRepaymentAtDisbursement() &&
transaction.getLoanChargesPaid().contains(loanCharge)) {
Review comment:
Type of loanCharge and transaction.getLoanChargePaid() are not compatible
and so spotbugs throw an error. If they are incompatible, how is this going to
ever be TRUE as the second expression in the if statement will be FALSE? I
removed this so we can discuss with someone who has more domain knowledge and
understands the code. I might be missing something here. @vishwasbabu
@nazeer1100126 @Nayan Help me understand this..please...
I may put this back and suppress the spotbug check for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
