vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari
instead of Tomcat Connection Pool
URL: https://github.com/apache/fineract/pull/722#discussion_r389395046
##########
File path: fineract-provider/src/test/resources/META-INF/context.xml
##########
@@ -23,7 +23,6 @@
<Context>
<Resource type="javax.sql.DataSource" name="jdbc/mifosplatform-tenants"
- driverClassName="org.drizzle.jdbc.DrizzleDriver"
url="jdbc:mysql:thin://localhost:3306/mifosplatform-tenants"
- username="root" password="mysql" validationQuery="select 1"
maxActive="10"
- maxIdle="4" />
+ driverClassName="org.drizzle.jdbc.DrizzleDriver"
jdbcUrl="jdbc:mysql:thin://localhost:3306/mifosplatform-tenants"
+ username="root" password="mysql" />
Review comment:
well spotted.. but you should be able to either just remove that `configFile
= file('src/test/resources/META-INF/context.xml')` in
[build.gradle](https://github.com/apache/fineract/blob/develop/fineract-provider/build.gradle),
because according to https://github.com/bmuschko/gradle-tomcat-plugin it
should not be required; or if it's giving you trouble, you could just keep an
empty
[context.xml](https://github.com/apache/fineract/blob/develop/fineract-provider/src/test/resources/META-INF/context.xml)
(but I don't think you need to; I expect you'll find that you can simply
entirely remove that file, and any references to it that you'll find, as part
of your work on this PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
