vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari
instead of Tomcat Connection Pool
URL: https://github.com/apache/fineract/pull/722#discussion_r390225521
##########
File path: fineract-provider/build.gradle
##########
@@ -82,6 +82,7 @@ dependencyManagement {
dependency 'joda-time:joda-time:+'
dependency 'org.apache.commons:commons-email:1.3.3'
dependency 'org.apache.commons:commons-lang3:+'
+ dependency 'com.zaxxer:HikariCP:3.4.2'
Review comment:
Would it be possible to get the HikariCP version from the Spring BOM, like
others? May be just using '+' as the version is enough, or perhaps you need to
list it elsewhere, like other dependencies?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
