vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari
instead of Tomcat Connection Pool
URL: https://github.com/apache/fineract/pull/722#discussion_r390254495
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/db/DataSourceProperties.java
##########
@@ -31,8 +31,7 @@
* -Dfineract.datasource.port=3307.
*/
// NOT a @Component - we do not want this to picked up by component scan, only
explicitly declared in DataSourceConfiguration (if that's active)
-public class DataSourceProperties extends PoolProperties {
-
+public class DataSourceProperties extends HikariConfig {
Review comment:
If you manage to delete `DataSourceConfiguration.java` (above), then I
suspect we can delete this entire class as well.. Or is there anything else
left that uses this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
