vorburger commented on issue #738: Glim gsim with test cases
URL: https://github.com/apache/fineract/pull/738#issuecomment-615438699
 
 
   > @vorburger, and finally build got passed by Travis. blush
   
   That was most likely more of a coincidence actually... FYI there were 2 
flaky tests, and sometimes it passes, and sometimes it failed.. :smile: 
Following #764 and #761 this would always pass the build (or not at least not 
fail because of integration tests) if you rebased this now. 
   
   I'm assuming that this PR fixes 
https://issues.apache.org/jira/browse/FINERACT-603, is this correct? I'd like 
to assign that issue to you instead of myself (or formerly Nazeer Shaik ) in 
JIRA to you, so that you "get credit" whenever someone will create Release 
Notes, but I cannot find you in JIRA - what is your ID on 
https://issues.apache.org/jira? If you do not have an account yet, perhaps this 
would be a great time to create one?
   
   I'll try to make time for a more details rewiew of this (big!) PR hopefully 
in the coming days.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to