nikpawar89 commented on a change in pull request #738: GSIM and GLIM with test
cases (FINERACT-603)
URL: https://github.com/apache/fineract/pull/738#discussion_r410953649
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java
##########
@@ -131,6 +162,16 @@ public AccountSummaryCollectionData
retrieveGroupAccountDetails(final Long group
return retrieveLoanAccountDetails(loanWhereClause, new Object[] {
clientId });
}
+ @Override
+ public List<LoanAccountSummaryData>
retrieveLoanAccountDetailsByGroupIdAndGlimAccountNumber(final Long
groupId,final String glimAccount) {
+ final LoanAccountSummaryDataMapper rm = new
LoanAccountSummaryDataMapper();
+ final String loanWhereClauseForGroupAndLoanType = " where l.group_id
=? and glim.account_number="+glimAccount+" and l.loan_type_enum=4";
Review comment:
can we pass GLIM account number as we are passing group id, appending it in
string doesn't look good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
