vorburger commented on a change in pull request #738: GSIM and GLIM with test
cases (FINERACT-603)
URL: https://github.com/apache/fineract/pull/738#discussion_r410718841
##########
File path: fineract-provider/src/main/resources/META-INF/persistence.xml
##########
@@ -28,6 +28,8 @@
<persistence-unit name="jpa-pu" transaction-type="RESOURCE_LOCAL">
<provider>org.apache.openjpa.persistence.PersistenceProviderImpl</provider>
<properties>
+ <property name="openjpa.jdbc.EagerFetchMode" value="none"/>
+ <property name="openjpa.jdbc.SubclassFetchMode" value="none"/>
Review comment:
These two OpenJPA configuration changes here (`EagerFetchMode` &
`SubclassFetchMode`) strike me as major data access changes that perhaps should
not be "hidden" within this PR.. would you be willing to raise a new JIRA and a
separate PR and remove this from here so that it can be reviewed and discussed
in its own right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
