nikpawar89 commented on a change in pull request #738: GSIM and GLIM with test
cases (FINERACT-603)
URL: https://github.com/apache/fineract/pull/738#discussion_r410973156
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationCommandFromApiJsonHelper.java
##########
@@ -91,7 +91,9 @@
LoanApiConstants.linkAccountIdParameterName,
LoanApiConstants.disbursementDataParameterName,
LoanApiConstants.emiAmountParameterName,
LoanApiConstants.maxOutstandingBalanceParameterName,
LoanProductConstants.graceOnArrearsAgeingParameterName,
LoanApiConstants.createStandingInstructionAtDisbursementParameterName,
- LoanApiConstants.isTopup, LoanApiConstants.loanIdToClose,
LoanApiConstants.datatables, LoanApiConstants.isEqualAmortizationParam,
LoanProductConstants.ratesParamName));
+ LoanApiConstants.isTopup, LoanApiConstants.loanIdToClose,
LoanApiConstants.datatables,
LoanApiConstants.isEqualAmortizationParam,LoanProductConstants.ratesParamName,
+ LoanApiConstants.applicationId, // glim specific
Review comment:
If locking mechanism is added- applicationID can be removed altogether. Try
the synchronization i suggested and omit this change if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
