xurror commented on a change in pull request #915:
URL: https://github.com/apache/fineract/pull/915#discussion_r428069678
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountCharge.java
##########
@@ -474,7 +475,7 @@ public void update(final BigDecimal amount, final LocalDate
dueDate, final Month
break;
case PERCENT_OF_AMOUNT:
this.percentage = newValue;
- this.amountPercentageAppliedTo = null;
+ this.amountPercentageAppliedTo = BigDecimal.ZERO;
Review comment:
Can't tell for sure, Just know it's a nullable field and as null,
spotbugs throws an error when the value is passed to
`update.percentageOf(BigDecimal, BigDecimal)`. So I just replaced that
particular instance where I needed it to be something other than null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
