xurror commented on a change in pull request #915:
URL: https://github.com/apache/fineract/pull/915#discussion_r428228209
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountCharge.java
##########
@@ -474,7 +475,7 @@ public void update(final BigDecimal amount, final LocalDate
dueDate, final Month
break;
case PERCENT_OF_AMOUNT:
this.percentage = newValue;
- this.amountPercentageAppliedTo = null;
+ this.amountPercentageAppliedTo = BigDecimal.ZERO;
Review comment:
Hmm, This is troublesome. I thought this was the most subtle way of
going around this. I don't think multiplication by null is possible. This is
actually some faulty method but I think I'll see how to make spotsbug ignore
this just to stay on the safe side
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
