maektwain commented on a change in pull request #915:
URL: https://github.com/apache/fineract/pull/915#discussion_r428231333



##########
File path: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccountCharge.java
##########
@@ -474,7 +475,7 @@ public void update(final BigDecimal amount, final LocalDate 
dueDate, final Month
                 break;
                 case PERCENT_OF_AMOUNT:
                     this.percentage = newValue;
-                    this.amountPercentageAppliedTo = null;
+                    this.amountPercentageAppliedTo = BigDecimal.ZERO;

Review comment:
       Yes true, might be just initializing it with null and then populating 
with real values... Could be like that




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to