vorburger commented on pull request #943: URL: https://github.com/apache/fineract/pull/943#issuecomment-638080245
@thesmallstar I have full faith in you that you'll be able to figure out your `git reset` issues! :smiley_cat: > If I am not wrong "epf" includes all preferences(also the formatting ), but XML only has formatting settings (which is required by formator). They are not interchangeable, we need to have them both. And spotless won't support the epf, it only takes XML as an argument hence I made it. Edit: preferences cannot be exported as XML, and spotless only wants .XML (hence this extra step was needed Understood, but https://github.com/diffplug/spotless/blob/master/ECLIPSE_SCREENSHOTS.md gives me the impression that x1 EPF can be exported as xN XML - one for formatting, another one for Organize Imports, right? Let's do that. One that the Spotless doc doesn't show is for _Preferences > Java > Code Style > Clean Up_ (which in the EPF I've extensively customized for Fineract) - that's your 3rd XML. You can ignore Code Templates (because I have not customized those; although it could be nice to have them with the License header... but that's separate). Once you have done that, for any other Preferences see what you can spot in the EPF that is still not in the XML. What we should do IMHO, to avoid "redundancy", is just to manually edit and strip out anything from the EPF that you have put into XML, and only keep a very small EPF! At least 2 things which I suspect will be left that I see (in Eclipse) are the _Preferences > Java > Compiler > ..._ settings, as well as the _Preferences > Java > Editor > Save Actions_. Those are great, and in January I have extensively customized those for Fineract. [It looks like there is no easy way to export those](https://stackoverflow.com/questions/22891425/eclipse-importexport-actions-in-save-actions-option) (link), so just keep anything related to that in a manually edited small EPF. PS: Here's an idea for a future follow-up, not for this PR: I think the right way to eventually replace what will be left in an EPF is to try to put it all into a Gradle configuration. But reading https://github.com/gradle/gradle/issues/856, it looks like this is not (easily) possible, yet... :sob: An alternative in the mean time may be to simply switch from workspace global properties in the EPF to actually just have `fineract-provider/.settings/org.eclipse.jdt.core.prefs` in Git (instead of `.gitignore`) instead of using EPF, assuming that it contain what will be left in the EPF. I can make that switch later, once we are done with this PR (unless you want to already do it as part of this here). Hope this makes sense and helps and is not too confusing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
