vorburger commented on pull request #943: URL: https://github.com/apache/fineract/pull/943#issuecomment-640211912
> What I removed from .epf is correct(doubtful about end part) I'm struggling to (easily) see the diff in the .epf, because you've included all changed .java files again (by mistake?), can you remove those, and keep that local, to make both my review and the eventual merge easier? That way, whenever we'll be good here, I'll just run it myself and immediately merge it - thus avoid conflicts. Makes sense? BTW are you also going to remove `config/google-checks-updated.xml` ? We agreed that we don't care about that, but want to just migrate the (my) Fineract specific EPF to XML - right? > Did I use the wrong import order? I found /instance/org.eclipse.jdt.ui/org.eclipse.jdt.ui.importorder=java;javax;org;com; It seems something is wrong, should we be doing it alphabetically(Also as in checkstyle) , and also consider -> import io.* type too? Yes you are right we want pure alphabetical import order, no grouping or java first... but I'm confused, where did you find `org.eclipse.jdt.ui.importorder=java;javax;org;com` ? https://github.com/apache/fineract/blob/develop/config/fineractdev-eclipse-preferences.epf#L463 has `/instance/org.eclipse.jdt.ui/org.eclipse.jdt.ui.importorder=;` and https://github.com/apache/fineract/blob/develop/fineract-provider/config/checkstyle/checkstyle.xml#L64 has `<module name="CustomImportOrder"> <property name="thirdPartyPackageRegExp" value=".*"/> <property name="sortImportsInGroupAlphabetically" value="true"/>` which to me seems right, that's what we want - agreed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
