vorburger commented on a change in pull request #943:
URL: https://github.com/apache/fineract/pull/943#discussion_r436362877
##########
File path: config/importConfig.importorder
##########
@@ -0,0 +1,6 @@
+#Organize Import Order
+#Thu Jun 04 03:11:49 IST 2020
+0=java
+1=javax
+2=org
+3=com
Review comment:
Nope, we do NOT want this, agreed? See longer comment in main discussion
thread.
##########
File path: fineract-provider/build.gradle
##########
@@ -192,6 +194,27 @@ jacocoTestReport{
}
}
+spotless {
+ format 'misc', {
+ target '**/*.md', '**/*.properties', '**/*.gradle', '**/.gitignore',
'**/*.yml', '**/*.xml', '**/**.json', '**/*.sql'
+ targetExclude '**/build/**', '**/bin/**'
+ indentWithSpaces(4)
+ trimTrailingWhitespace()
Review comment:
could `trimTrailingWhitespace()` + `endWithNewline()` be moved "out" of
'misc' and 'java' at the start (or end) of the spotless configuration, together
with `lineEndings`, so that it applies to everything? Or is that not how this
configuration works?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
