vorburger commented on a change in pull request #990:
URL: https://github.com/apache/fineract/pull/990#discussion_r436992125
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignDropdownReadPlatformServiceImpl.java
##########
@@ -70,19 +71,18 @@ public SmsCampaignDropdownReadPlatformServiceImpl(final
SmsConfigUtils smsConfig
public Collection<SmsProviderData> retrieveSmsProviders() {
Collection<SmsProviderData> smsProviderOptions = new ArrayList<>();
String hostName = "" ;
- try {
Map<String, Object> hostConfig =
this.smsConfigUtils.getMessageGateWayRequestURI("smsbridges", null);
URI uri = (URI) hostConfig.get("uri");
hostName = uri.getHost() ;
HttpEntity<?> entity = (HttpEntity<?>) hostConfig.get("entity");
ResponseEntity<Collection<SmsProviderData>> responseOne =
restTemplate.exchange(uri, HttpMethod.GET, entity,
new
ParameterizedTypeReference<Collection<SmsProviderData>>() {});
+ if (!responseOne.getStatusCode().equals(HttpStatus.OK)) {
Review comment:
I'm not 100% sure if PlatformDataIntegrityException is "correct" here,
but don't really have a better idea without more closely than I have time for,
and it probably doesn't really matter all that much, anyway. One fine day we
should look into and then write up Guidance in the README about which exact
Fineract Exception type to use in which "layer" (e.g. *Resource VS *Service).
@ptuomola I doubt that's something you would fancy digging into?
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerManagementReadPlatformServiceImpl.java
##########
@@ -261,8 +261,10 @@ private String getTellerCriteria(final String sqlSearch,
final Long officeId, fi
extraCriteria.append(" and status = 300 ");
} else if (status.equalsIgnoreCase("inActive")) {
extraCriteria.append(" and status = 0 ");
- } else if (status.equalsIgnoreCase("all")) {} else {
+ } else {
+ if (!status.equalsIgnoreCase("all")){
Review comment:
Why changing this? Just curious..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
