vorburger commented on a change in pull request #990:
URL: https://github.com/apache/fineract/pull/990#discussion_r439086408
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/organisation/teller/service/TellerManagementReadPlatformServiceImpl.java
##########
@@ -261,8 +261,10 @@ private String getTellerCriteria(final String sqlSearch,
final Long officeId, fi
extraCriteria.append(" and status = 300 ");
} else if (status.equalsIgnoreCase("inActive")) {
extraCriteria.append(" and status = 0 ");
- } else if (status.equalsIgnoreCase("all")) {} else {
+ } else {
+ if (!status.equalsIgnoreCase("all")){
Review comment:
got it, thanks for clarifying!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]