vorburger commented on a change in pull request #990:
URL: https://github.com/apache/fineract/pull/990#discussion_r439088743
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignDropdownReadPlatformServiceImpl.java
##########
@@ -78,8 +78,9 @@ public SmsCampaignDropdownReadPlatformServiceImpl(final
SmsConfigUtils smsConfig
ResponseEntity<Collection<SmsProviderData>> responseOne =
restTemplate.exchange(uri, HttpMethod.GET, entity,
new
ParameterizedTypeReference<Collection<SmsProviderData>>() {});
smsProviderOptions = responseOne.getBody();
- if (!responseOne.getStatusCode().equals(HttpStatus.OK)) {
- }
+ //Better approch? Maybe log/throw exception that this happen?
+ // if (!responseOne.getStatusCode().equals(HttpStatus.OK)) {
+ // }
} catch (Exception e) {
}
Review comment:
this was done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
