vorburger commented on a change in pull request #1149:
URL: https://github.com/apache/fineract/pull/1149#discussion_r453977085
##########
File path:
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/ClientLoanIntegrationTest.java
##########
@@ -3195,7 +3195,7 @@ public void
testLoanScheduleWithInterestRecalculation_WITH_REST_SAME_AS_REPAYMEN
String prepayAmount = String.valueOf(prepayDetail.get("amount"));
validateNumberForEqualWithMsg("verify pre-close amount", "3551.93",
prepayAmount);
todaysDate = Calendar.getInstance(Utils.getTimeZoneOfTenant());
- String LOAN_REPAYMENT_DATE = dateFormat.format(todaysDate.getTime());
+ final String LOAN_REPAYMENT_DATE =
dateFormat.format(todaysDate.getTime());
Review comment:
I would actually make this lower case, because it's not a constant.
##########
File path:
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/AccountingScenarioIntegrationTest.java
##########
@@ -802,10 +802,10 @@ public void
checkPeriodicAccrualAccountingTillCurrentDateFlow() throws Interrupt
float totalInterest = (float)
loanSchedule.get(1).get("interestOriginalDue");
DecimalFormat numberFormat = new DecimalFormat("#.00", new
DecimalFormatSymbols(Locale.US));
- float INTEREST_4_DAYS = totalInterest / totalDaysInPeriod * 4;
- INTEREST_4_DAYS = Float.valueOf(numberFormat.format(INTEREST_4_DAYS));
+ float interest4Days = totalInterest / totalDaysInPeriod * 4;
+ interest4Days = Float.valueOf(numberFormat.format(interest4Days));
Review comment:
I don't understand what this does (why it's needed) - but it has nothing
to do with the Checkstyle change..
##########
File path:
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/ClientLoanIntegrationTest.java
##########
@@ -4843,7 +4843,7 @@ public void testLoanRefundByTransferCashBasedAccounting()
{
// refund 20 means paid: principal 1980, interest 240, fees 50, penalty
// 0
- Float TRANSFER_AMOUNT = 20f;
+ Float transferAmountValue = 20f;
Review comment:
If this is a real constant, make it final and upper case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
