thesmallstar commented on pull request #1149: URL: https://github.com/apache/fineract/pull/1149#issuecomment-657831575
@vorburger What have I done here is: 1. If a variable is not changed after initialisation I have made it final, and then it allows XYZ_ABC type of naming style. 2. If a variable is changed and we cannot make it final, then we need to have to follow camelcasing (abcXyz) . So, if a var is not changed I have made it final. Else I have forced it to follow the required regex. Since we want only static final to have XYZ_ABC naming, I will make every name ( final/non-final) to follow camelcasing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
